fix filter for next round period 0 votes#62
Merged
Vervious merged 5 commits intoalgorand:masterfrom Jun 20, 2019
Merged
Conversation
This fixes a deviation from the spec. Currently, the code
(accidentally) filters all votePresent and voteVerified events
from the next round, if myPlayer.Period is large. Instead,
whether we filter votes from the next round should not be a
function of current period. As specified in the spec, we allow
votes with vote.Round = player.Round + 1 and vote.Period == 0
and vote.Step = {propose,soft,cert,next}
Contributor
Author
|
Fixes #63 |
derbear
reviewed
Jun 20, 2019
derbear
reviewed
Jun 20, 2019
Contributor
Author
|
See algorandfoundation/specs#1 for spec update |
derbear
approved these changes
Jun 20, 2019
pzbitskiy
pushed a commit
to pzbitskiy/go-algorand
that referenced
this pull request
May 1, 2020
Add goal app create --on-completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a deviation from the spec. Currently, the code (accidentally) filters all votePresent and voteVerified events from the next round, if myPlayer.Period is large. Instead, whether we filter votes from the next round should not be a function of current period. As specified in the spec, we allow votes with vote.Round = player.Round + 1 and vote.Period == 0 and vote.Step = {propose,soft,cert,next}. We continue to filter all FPR votes.
Test Plan
Added a unit test for this scenario